Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): fixed InputField default values #7464

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(app): fixed InputField default values #7464

merged 1 commit into from
Dec 19, 2024

Conversation

rikublock
Copy link
Contributor

Summary

Address non-determinism in the typegen creation process. Set fixed default values.

Related Issues / Discussions

#7463

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations labels Dec 19, 2024
@rikublock rikublock mentioned this pull request Dec 19, 2024
Merged
4 tasks
psychedelicious
psychedelicious approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooooh good catch!

@psychedelicious psychedelicious enabled auto-merge (rebase) December 19, 2024 22:21
@psychedelicious psychedelicious force-pushed the riku/fix-fp32-default-value branch from d6cc1de to 9117fac Compare December 19, 2024 22:21
@psychedelicious psychedelicious merged commit 525cb38 into invoke-ai:main Dec 19, 2024
14 checks passed
@rikublock rikublock mentioned this pull request Dec 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
invocations PRs that change invocations python PRs that change python files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rikublock @psychedelicious