Deprecate ram
/vram
configs for smoother migration path to dynamic limits
#7526
+15
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes:
ram
andvram
configs. If these are set in invokeai.yaml, they will be ignored.max_cache_ram_gb
andmax_cache_vram_gb
configs with the same definitions as the old configs.The main motivation of this change is to make the migration path smoother for users who had previously added
ram
/vram
to their config files. Now, these users will be automatically migrated into the new dynamic limit behavior (which is better in most cases). These users will have to manually re-addmax_cache_ram_gb
andmax_cache_vram_gb
to their configs if they wish to go back to specifying manual limits.Related Issues / Discussions
See the release notes for RC v5.6.0rc1 for the old migration behavior that we are trying to improve: https://github.com/invoke-ai/InvokeAI/releases/tag/v5.6.0rc1
QA Instructions
ram
orvram
are present in a user'sinvokeai.yaml
, these values are ignored.max_cache_ram_gb
andmax_cache_vram_gb
are applied, if set.Merge Plan
Checklist
What's New
copy (if doing a release after this PR)