feat: add uv to PATH when creating terminal #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a `bin` dir to `process.resourcesPath` and put `uv` there instead of directly in `process.resourcesPath` - Adjust some variable names in util.ts to prevent clobbering the `path` module - Add util to get the new `bin` path, update `getUVExecutablePath` to use this - Prepend the new `bin` path when creating PTYs so that the `uv` executable is available
psychedelicious
force-pushed
the
psyche/feat/add-uv-to-path
branch
from
f022658 to
5486091
Compare
The PTY manager shouldn't be responsible for this. Instead, we should run commands after instantiating the PTY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindir toprocess.resourcesPathand putuvthere instead of directly inprocess.resourcesPathpathmodulebinpath, updategetUVExecutablePathto use thisbinpath when creating PTYs so that theuvexecutable is availablePtyManagerclass