Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node.js 16, remove ecmaVersion question, pin chai to v4 #1082

Merged
merged 6 commits into from
Jan 5, 2024

Conversation

AlCalzone
Copy link
Collaborator

@AlCalzone AlCalzone commented Jan 5, 2024

PR Checklist:

  • Provide a meaningful description to this PR or mention which issues this fixes.
  • Ensure the project builds with npm run build
  • Add tests for your change. This includes negative tests (i.e. inputs that need to fail) as well as baseline tests (i.e. how should the directory structure look like?).
  • Run the test suite with npm test
  • If there are baseline changes, review them and make a separate commit for them with the comment "accept baselines" if they are desired changes
  • If you added a required option, also add it to the template creation (.github/create_templates.ts)
  • Add a detailed migration description to docs/updates explaining what the user needs to do when manually updating an existing project
  • Add your changes to CHANGELOG.md (referencing the migration description and this PR or the issue you fixed)

Description:
Removes Node.js 16 from the creator and the templates. Also simplifies the ESlint config by using the latest parser. And pins chai to v4 as it is incompatible with chai-as-promised

closes: #1076
fixes: #1080
fixes: #1062
fixes: #1047

@AlCalzone AlCalzone changed the title Drop Node.js 16, remove ecmaVersion question Drop Node.js 16, remove ecmaVersion question, pin chai to v4 Jan 5, 2024
@AlCalzone AlCalzone changed the title Drop Node.js 16, remove ecmaVersion question, pin chai to v4 Drop Node.js 16, remove ecmaVersion question, pin chai to v4 Jan 5, 2024
@AlCalzone AlCalzone merged commit c6655d3 into master Jan 5, 2024
6 checks passed
@AlCalzone AlCalzone deleted the node18 branch January 5, 2024 19:31
AlCalzone added a commit that referenced this pull request Jan 5, 2024
* (AlCalzone) Change supported Node.js versions to 18 / 20 (#1082) · [Migration guide](docs/updates/20240105_min_node18.md)
* (AlCalzone) Simplify maintenance of ESLint config by using the `"latest"` parser version (#1082) · [Migration guide](docs/updates/20240105_ecmaversion_latest.md)
* (AlCalzone) Pin `chai` dependency to version 4 (#1082)
AlCalzone added a commit that referenced this pull request Jan 15, 2024
* (AlCalzone) Fixed an issue with TypeScript tests caused by #1082 (fixes #1084)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict in dependencies Omit node 16 Bump ecmaVersion to 2022 at .eslintcr.json
1 participant