Added adapter for WARP chargers to sources-dist.json

[pottio]

Fixes ioBroker/AdapterRequests#690

[pottio]

Ich habe bereits einige positive Rückmeldungen erhalten, sowohl für WARP 1, als auch WARP 2 Charger. Was fehlt noch, damit der PR gemerged werden kann?

[Apollon77]

Der Adapter-Review durch mich fehlt noch.

[Apollon77]

Hi, here some Review feedback:

• (Must) Please do not use setObject for state objects! e.g. https://github.com/pottio/ioBroker.warp/blob/c6a19cd1aead22549e638144b6f60de91ddb380f/src/warp/warp-service.ts#L285 ... better option is setObjectNotExistAsync or extendObjects (yes extend also works when object do not exist before)
• Question/Hint: How many states that allow actions you usually have? also: how many single subscribes you do? Starting with 100 or such it is cheaper in sum to do a "*" subscribe and filter inconing data on receive :-)
• Info: The password encryption can be made more simple with the new options like "encryptedNative" and such , but works. But you should set protectedNative for "Passwordd" field to prevent access to the encrypted password from other adapters
• Info: The "news" entry for 0.0.2 in io-package seems completely broken.
• Info: In unload/terminate ... in fact no need to unsubscribe because this will happen automatically ... maybe tear doown your service first ... https://github.com/pottio/ioBroker.warp/blob/c6a19cd1aead22549e638144b6f60de91ddb380f/src/warp/warp-service.ts#L56
• Info: Do you think the idea with "create objects within first 60s after start" is really the best approch? you can also simply remember which devices you initialized already or such ... more flexible and especially old systems could have issues in load situations with 60s :-)

Please adjust the first point (and maybe more if you like) and publish a new version and poke again here. Thank you.

[Apollon77]

@pottio Ready for re-review?

[pottio]

Hi, thanks for your feedback.

• (Must) Please do not use setObject for state objects! e.g. https://github.com/pottio/ioBroker.warp/blob/c6a19cd1aead22549e638144b6f60de91ddb380f/src/warp/warp-service.ts#L285 ... better option is setObjectNotExistAsync or extendObjects (yes extend also works when object do not exist before)
  > Changed object creation/update to extendObjectAsync(...)
• Question/Hint: How many states that allow actions you usually have? also: how many single subscribes you do? Starting with 100 or such it is cheaper in sum to do a "*" subscribe and filter inconing data on receive :-)
  > In total less than 20 states depending which WARP charger is used
• Info: The password encryption can be made more simple with the new options like "encryptedNative" and such , but works. But you should set protectedNative for "Passwordd" field to prevent access to the encrypted password from other adapters
  > Used "encryptedNative" instead of unnecessary implementation within adapter/admin page. Also protected "user" and "password" via "protectedNative" feature
• Info: The "news" entry for 0.0.2 in io-package seems completely broken.
  > Fixed
• Info: In unload/terminate ... in fact no need to unsubscribe because this will happen automatically ... maybe tear doown your service first ... https://github.com/pottio/ioBroker.warp/blob/c6a19cd1aead22549e638144b6f60de91ddb380f/src/warp/warp-service.ts#L56
  > Removed unnecessary state unsubscribe implementations
• Info: Do you think the idea with "create objects within first 60s after start" is really the best approch? you can also simply remember which devices you initialized already or such ... more flexible and especially old systems could have issues in load situations with 60s :-)
  > Created a new improvement issue for that topic (Improve object/device initialization pottio/ioBroker.warp#32)

Please review again. Thanks!

[Apollon77]

Hi,

near to complete :-)

• with the ecnrypt change please add a common.globalDependencies with admin >= 4.0.9 to io-package.
  Please add that and release update to npm and we are redy to merge! Thanky ou for your support!

Ingo

[pottio]

Hi, I added the common.globalDependencies with admin >= 4.0.9 to io-package and deployed a new version :)

[GermanBluefox]

Automated adapter checker

ioBroker.warp

👍 No errors found

• 👀 [W400] Cannot find "warp" in latest repository

Add comment "RE-CHECK!" to start check anew

[Apollon77]

Thank you, and welcome to the repo :-)