Add mywallbox Adapter to latest #1899

SKB-CGN · 2022-08-15T12:25:11Z

Adapter for Cloud based Wallboxes like Pulsar or Pulsar Plus

Apollon77 · 2022-08-15T12:31:02Z

Hi, thank you for your adapter.

Is the adapter for Pulsar Wallboxes only? Then "Wallbox" as name is too generic in my eyes ... or do you pan to add more other such? Could you please rename it to pulsar-wallbox or such?

SKB-CGN · 2022-08-15T12:33:01Z

Hi, thank you for your adapter.

Is the adapter for Pulsar Wallboxes only? Then "Wallbox" as name is too generic in my eyes ... or do you pan to add more other such? Could you please rename it to pulsar-wallbox or such?

The Company is named "Wallbox" therefore i choosed this name.

Apollon77 · 2022-08-15T12:40:09Z

wow ... puuhh ... a company name which matches a "in the meantime commodoty name of a device type" :-( I will discuss it in core team...
But I hope you also understand my point of view?

SKB-CGN · 2022-08-15T12:59:34Z

Sure, understand it. Never mind. They even own www.wallbox.com as their domain.
So its most common name for product and company ;)

Could you do the checks needed for the adapter in the meantime? Thanks beforehand!

SKB-CGN · 2022-08-17T06:28:44Z

Hi,
do we have some news here?

Apollon77 · 2022-08-17T07:30:01Z

Yes, we discussed yesterday. WOuld it be an issue torename tzo "my-wallbox" so we match the name of that cloud servcie you connect to?

Additionally please state in the readme exactly that it is for Wallboxes from company "wallbox" or such ... right now also the Readme could be easiely read "works for all wallboxes". The same for io-package title/tileLang and desc fields please.

This is a special case, but we want to avoid user confusion.

Additionally please adjust the links in the repo file to use raw.githubusercontent.com like the others ... github.com is not a CDN service ...

Thnak you very much for your understanding and support on this

Changed name to My-Wallbox as requested

SKB-CGN · 2022-08-17T09:01:41Z

Hi,
would you please check the things again.

I have updated the name to My-Wallbox and changed (hopefully) all necessary dependencies and files.

Thank you!

Apollon77 · 2022-08-17T09:10:53Z

I will do the adapter review in the next days ...

SKB-CGN · 2022-08-17T09:20:26Z

Great, but now i have the problem, that the adapter is not working anymore ... i do not know, whats going on.

Apollon77 · 2022-08-17T09:32:02Z

Hm ... data on github looks fine ... what error you get?

Changed Name to MyWallbox

SKB-CGN · 2022-08-17T09:49:34Z

The adapter is not doing anything. No commands running, no Interval is working. Nothing.

Even not able to change to debug to see some output.

Apollon77 · 2022-08-17T09:51:27Z

Code wise looks good ... also github actionsstart tghe adapter ... how you test locally?

SKB-CGN · 2022-08-17T09:59:08Z

i created the adapter with adapter creator and everytime i change the code, i do iobroker upload mywallbox

Apollon77 · 2022-08-17T10:10:26Z

but you also reinstalled the adapter after that namechange completely?

SKB-CGN · 2022-08-17T10:35:36Z

Holy bible. I missed an error-handling. Will fix that shortly.

SKB-CGN · 2022-08-17T10:40:32Z

Now its working again. Thanks for waiting.

SKB-CGN · 2022-08-31T06:20:51Z

@Apollon77 Do we have some news here? :)

Apollon77 · 2022-08-31T19:01:58Z

Yes, after vacation, wasn't able to do it before

SKB-CGN · 2022-09-16T07:14:46Z

Can someone please tell me, how "ioBroker.my-wallbox" can be removed here? I needed to change the name and the check always goes through my-wallbox either instead of only using mywallbox.

Thank you!

Apollon77 · 2022-09-16T08:20:05Z

All good ... the checker only checks the initial repo file change ... so clean would be new PR ... but in this case "known", so all fine

SKB-CGN · 2022-09-16T08:25:52Z

Ok and all things are good now?

Apollon77 · 2022-09-16T20:24:07Z

Hi,
here my review comments:

please sort in the entry in this PR alphabetically
please fix that link https://github.com/SKB-CGN/ioBroker.mywallbox/blob/main/io-package.json#L131 (blob is too much)
please also add an emoty "password" field in native https://github.com/SKB-CGN/ioBroker.mywallbox/blob/main/io-package.json#L151 as default value
Please add a "common.globalDependencies with admin >= 4.0.9 to io-package because you use the automatic encryption
you configured the automatic encryption but still have code in admin to encrypt passwords and to decrypt in main.js ... you you encrypt it twice right now ... Please remove https://github.com/SKB-CGN/ioBroker.mywallbox/blob/main/admin/index_m.html#L63 and the main.js code (would be breaking for all current users)
Note: Using intervals for external server communication is not ideal (https://github.com/SKB-CGN/ioBroker.mywallbox/blob/d3e6a7543c1eb7ee85660d31b14672761cf4e28a/main.js#L444) ... can be done but could generate issues- seee infos in best practices
you should set a timeout for the external communication which is always lower then your interval (or not use an interval at all - see above)
Please check roles - e.g. https://github.com/SKB-CGN/ioBroker.mywallbox/blob/d3e6a7543c1eb7ee85660d31b14672761cf4e28a/main.js#L806 ... an indicator is defined as boolean red-only and not for numbers, see Role definitions in https://github.com/ioBroker/ioBroker/blob/master/doc/STATE_ROLES.md

Thank you for checking and adjusting,

Ingo

mcm1957 · 2024-09-17T19:49:00Z

Feel free to take next week too. I'm on holidays next week and will not be able to do a review next week anyway.

github-actions · 2024-09-18T07:37:19Z

Automated adapter checker

blob

-

❗ [E000] FATAL: cannot access repository https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob
❗ [E999] GLOBAL ERROR: [object Object], {"message":"Request failed with status code 404","name":"AxiosError","stack":"AxiosError: Request failed with status code 404\n at settle (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:2019:12)\n at Unzip.handleStreamEnd (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:3135:11)\n at Unzip.emit (node:events:529:35)\n at endReadableNT (node:internal/streams/readable:1400:12)\n at process.processTicksAndRejections (node:internal/process/task_queues:82:21)\n at Axios.request (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:4287:41)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)","config":{"transitional":{"silentJSONParsing":true,"forcedJSONParsing":true,"clarifyTimeoutError":false},"adapter":["xhr","http","fetch"],"transformRequest":[null],"transformResponse":[null],"timeout":0,"xsrfCookieName":"XSRF-TOKEN","xsrfHeaderName":"X-XSRF-TOKEN","maxContentLength":-1,"maxBodyLength":-1,"env":{},"headers":{"Cache-Control":"no-cache","Pragma":"no-cache","Expires":"0","User-Agent":"axios/1.7.7","Accept-Encoding":"gzip, compress, deflate, br"},"cache":false,"method":"get","url":"https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob"},"code":"ERR_BAD_REQUEST","status":404}

ioBroker.my-wallbox

-

❗ [E999] GLOBAL ERROR: ReferenceError: packageJson is not defined, {}

ioBroker.mywallbox

-

❗ [E254] Versions "0.0.17, 0.0.16, 0.0.15" listed at common.news at io-package.json do not exist at NPM. Please remove from news section.
👀 [S522] Please consider migrating to admin 5 UI (jsonConfig).
👀 [S526] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
👀 [W401] Cannot find "mywallbox" in latest repository

Add comment "RE-CHECK!" to start check anew

github-actions · 2024-09-18T07:49:40Z

Automated adapter checker

blob

-

❗ [E000] FATAL: cannot access repository https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob
❗ [E999] GLOBAL ERROR: [object Object], {"message":"Request failed with status code 404","name":"AxiosError","stack":"AxiosError: Request failed with status code 404\n at settle (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:2019:12)\n at Unzip.handleStreamEnd (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:3135:11)\n at Unzip.emit (node:events:529:35)\n at endReadableNT (node:internal/streams/readable:1400:12)\n at process.processTicksAndRejections (node:internal/process/task_queues:82:21)\n at Axios.request (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:4287:41)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)","config":{"transitional":{"silentJSONParsing":true,"forcedJSONParsing":true,"clarifyTimeoutError":false},"adapter":["xhr","http","fetch"],"transformRequest":[null],"transformResponse":[null],"timeout":0,"xsrfCookieName":"XSRF-TOKEN","xsrfHeaderName":"X-XSRF-TOKEN","maxContentLength":-1,"maxBodyLength":-1,"env":{},"headers":{"Cache-Control":"no-cache","Pragma":"no-cache","Expires":"0","User-Agent":"axios/1.7.7","Accept-Encoding":"gzip, compress, deflate, br"},"cache":false,"method":"get","url":"https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob"},"code":"ERR_BAD_REQUEST","status":404}

ioBroker.my-wallbox

-

❗ [E999] GLOBAL ERROR: ReferenceError: packageJson is not defined, {}

ioBroker.mywallbox

-

❗ [E254] Versions "0.0.17, 0.0.16, 0.0.15" listed at common.news at io-package.json do not exist at NPM. Please remove from news section.
👀 [S522] Please consider migrating to admin 5 UI (jsonConfig).
👀 [S526] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
👀 [W401] Cannot find "mywallbox" in latest repository

Add comment "RE-CHECK!" to start check anew

github-actions · 2024-09-18T08:01:27Z

Automated adapter checker

blob

-

❗ [E000] FATAL: cannot access repository https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob
❗ [E999] GLOBAL ERROR: [object Object], {"message":"Request failed with status code 404","name":"AxiosError","stack":"AxiosError: Request failed with status code 404\n at settle (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:2019:12)\n at Unzip.handleStreamEnd (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:3135:11)\n at Unzip.emit (node:events:529:35)\n at endReadableNT (node:internal/streams/readable:1400:12)\n at process.processTicksAndRejections (node:internal/process/task_queues:82:21)\n at Axios.request (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:4287:41)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)","config":{"transitional":{"silentJSONParsing":true,"forcedJSONParsing":true,"clarifyTimeoutError":false},"adapter":["xhr","http","fetch"],"transformRequest":[null],"transformResponse":[null],"timeout":0,"xsrfCookieName":"XSRF-TOKEN","xsrfHeaderName":"X-XSRF-TOKEN","maxContentLength":-1,"maxBodyLength":-1,"env":{},"headers":{"Cache-Control":"no-cache","Pragma":"no-cache","Expires":"0","User-Agent":"axios/1.7.7","Accept-Encoding":"gzip, compress, deflate, br"},"cache":false,"method":"get","url":"https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob"},"code":"ERR_BAD_REQUEST","status":404}

ioBroker.my-wallbox

-

❗ [E999] GLOBAL ERROR: ReferenceError: packageJson is not defined, {}

ioBroker.mywallbox

-

❗ [E254] Versions "0.0.17, 0.0.16" listed at common.news at io-package.json do not exist at NPM. Please remove from news section.
👀 [S522] Please consider migrating to admin 5 UI (jsonConfig).
👀 [S526] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
👀 [W401] Cannot find "mywallbox" in latest repository

Add comment "RE-CHECK!" to start check anew

SKB-CGN · 2024-09-18T08:35:28Z

Hi @mcm1957 - i have updated all things and i think, the adapter is fully operable.
What do you think?

mcm1957 · 2024-09-18T08:45:19Z

Thanks for Info - I'll do a recheck

mcm1957 · 2024-11-01T18:04:06Z

RE-CHECK!

github-actions · 2024-11-01T18:04:39Z

Automated adapter checker

blob

-

❗ [E000] FATAL: cannot access repository https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob
❗ [E999] GLOBAL ERROR: AxiosError: Request failed with status code 404, {"message":"Request failed with status code 404","name":"AxiosError","stack":"AxiosError: Request failed with status code 404\n at settle (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:2019:12)\n at Unzip.handleStreamEnd (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:3135:11)\n at Unzip.emit (node:events:529:35)\n at endReadableNT (node:internal/streams/readable:1400:12)\n at process.processTicksAndRejections (node:internal/process/task_queues:82:21)\n at Axios.request (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:4287:41)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)","config":{"transitional":{"silentJSONParsing":true,"forcedJSONParsing":true,"clarifyTimeoutError":false},"adapter":["xhr","http","fetch"],"transformRequest":[null],"transformResponse":[null],"timeout":0,"xsrfCookieName":"XSRF-TOKEN","xsrfHeaderName":"X-XSRF-TOKEN","maxContentLength":-1,"maxBodyLength":-1,"env":{},"headers":{"Cache-Control":"no-cache","Pragma":"no-cache","Expires":"0","User-Agent":"axios/1.7.7","Accept-Encoding":"gzip, compress, deflate, br"},"cache":false,"method":"get","url":"https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob"},"code":"ERR_BAD_REQUEST","status":404}

ioBroker.my-wallbox

-

❗ [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.my-wallbox". Now is "iobroker.mywallbox"
❗ [E103] "common.name" in io-package.json must be equal to "my-wallbox'". Now is mywallbox
❗ [E251] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.my-wallbox
❗ [E999] GLOBAL ERROR: TypeError: Cannot read properties of undefined (reading 'latest'), {}
👀 [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json

ioBroker.mywallbox

-

❗ [E254] Versions "0.0.17, 0.0.16" listed at common.news at io-package.json do not exist at NPM. Please remove from news section.
👀 [S522] Please consider migrating to admin 5 UI (jsonConfig).
👀 [S526] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
👀 [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json
👀 [W401] Cannot find "mywallbox" in latest repository

Add comment "RE-CHECK!" to start check anew

SKB-CGN · 2024-11-11T08:25:28Z

RE-CHECK!

github-actions · 2024-11-11T08:26:02Z

Automated adapter checker

blob

-

❗ [E000] FATAL: cannot access repository https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob
❗ [E999] GLOBAL ERROR: AxiosError: Request failed with status code 404, {"message":"Request failed with status code 404","name":"AxiosError","stack":"AxiosError: Request failed with status code 404\n at settle (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:2019:12)\n at Unzip.handleStreamEnd (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:3135:11)\n at Unzip.emit (node:events:529:35)\n at endReadableNT (node:internal/streams/readable:1400:12)\n at process.processTicksAndRejections (node:internal/process/task_queues:82:21)\n at Axios.request (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:4287:41)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)","config":{"transitional":{"silentJSONParsing":true,"forcedJSONParsing":true,"clarifyTimeoutError":false},"adapter":["xhr","http","fetch"],"transformRequest":[null],"transformResponse":[null],"timeout":0,"xsrfCookieName":"XSRF-TOKEN","xsrfHeaderName":"X-XSRF-TOKEN","maxContentLength":-1,"maxBodyLength":-1,"env":{},"headers":{"Cache-Control":"no-cache","Pragma":"no-cache","Expires":"0","User-Agent":"axios/1.7.7","Accept-Encoding":"gzip, compress, deflate, br"},"cache":false,"method":"get","url":"https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob"},"code":"ERR_BAD_REQUEST","status":404}

ioBroker.my-wallbox

-

❗ [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.my-wallbox". Now is "iobroker.mywallbox"
❗ [E103] "common.name" in io-package.json must be equal to "my-wallbox'". Now is mywallbox
❗ [E251] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.my-wallbox
❗ [E999] GLOBAL ERROR: TypeError: Cannot read properties of undefined (reading 'latest'), {}

ioBroker.mywallbox

-

👍 No errors found

👀 [S522] Please consider migrating to admin 5 UI (jsonConfig).
👀 [S526] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
👀 [W401] Cannot find "mywallbox" in latest repository

Add comment "RE-CHECK!" to start check anew

SKB-CGN · 2024-11-11T08:28:27Z

@mcm1957 As all errors have been fixed, can we proceed?

mcm1957 · 2024-11-11T08:31:10Z

Yes i wll do as soon as I find time.
Have some backlog due to travel to Solingen (Meeting) and back.
Sorry.

SKB-CGN · 2024-11-11T08:33:07Z

Not a problem ;)
Take your time!

Added Wallbox Adapter

910b7a5

Apollon77 added the Adapter-Review needed A developer from the ioBroker Team will review the adapter, will provide comments or require changes label Aug 15, 2022

Update sources-dist.json

e62b9c6

Changed name to My-Wallbox as requested

Update sources-dist.json

e76eec7

Changed Name to MyWallbox

GermanBluefox added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Sep 6, 2022

ioBroker deleted a comment from Apollon77 Sep 6, 2022

Update sources-dist.json

59ca45e

github-actions bot added the *📬 a new comment has been added label Sep 17, 2024

mcm1957 added stale PR seems has no activity, will be closed after some time and removed *📬 a new comment has been added stale - marked for closing There was no feedback vom PR owner, PR will be closed. labels Sep 17, 2024

github-actions bot added the *📬 a new comment has been added label Sep 18, 2024

github-actions bot deleted a comment from mcm1957 Sep 18, 2024

github-actions bot deleted a comment from SKB-CGN Sep 18, 2024

github-actions bot added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Nov 1, 2024

github-actions bot deleted a comment from SKB-CGN Nov 1, 2024

github-actions bot added the *📬 a new comment has been added label Nov 11, 2024

github-actions bot deleted a comment from SKB-CGN Nov 11, 2024

Add mywallbox Adapter to latest #1899

Are you sure you want to change the base?

Add mywallbox Adapter to latest #1899

Conversation

SKB-CGN commented Aug 15, 2022 • edited Loading

Apollon77 commented Aug 15, 2022

SKB-CGN commented Aug 15, 2022

Apollon77 commented Aug 15, 2022

SKB-CGN commented Aug 15, 2022 • edited Loading

SKB-CGN commented Aug 17, 2022

Apollon77 commented Aug 17, 2022 • edited Loading

SKB-CGN commented Aug 17, 2022

Apollon77 commented Aug 17, 2022

SKB-CGN commented Aug 17, 2022

Apollon77 commented Aug 17, 2022

SKB-CGN commented Aug 17, 2022 • edited Loading

Apollon77 commented Aug 17, 2022

SKB-CGN commented Aug 17, 2022

Apollon77 commented Aug 17, 2022

SKB-CGN commented Aug 17, 2022

SKB-CGN commented Aug 17, 2022

SKB-CGN commented Aug 31, 2022

Apollon77 commented Aug 31, 2022

SKB-CGN commented Sep 16, 2022

Apollon77 commented Sep 16, 2022

SKB-CGN commented Sep 16, 2022

Apollon77 commented Sep 16, 2022

mcm1957 commented Sep 17, 2024

github-actions bot commented Sep 18, 2024

Automated adapter checker

github-actions bot commented Sep 18, 2024

Automated adapter checker

github-actions bot commented Sep 18, 2024

Automated adapter checker

SKB-CGN commented Sep 18, 2024

mcm1957 commented Sep 18, 2024

mcm1957 commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

Automated adapter checker

SKB-CGN commented Nov 11, 2024

github-actions bot commented Nov 11, 2024

Automated adapter checker

SKB-CGN commented Nov 11, 2024

mcm1957 commented Nov 11, 2024

SKB-CGN commented Nov 11, 2024

SKB-CGN commented Aug 15, 2022 •

edited

Loading

SKB-CGN commented Aug 15, 2022 •

edited

Loading

Apollon77 commented Aug 17, 2022 •

edited

Loading

SKB-CGN commented Aug 17, 2022 •

edited

Loading