-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update e3dc-rscp to 1.2.2 #2310
Conversation
This release has been created at 25.05.2023, 18:10:00 and is now not even available at latest repository. Release must be available at latest for one or two weeks and/or have a significant number of users and have no major issues. Please indicate why this release should be released immidiatly - otherwise I will keep it in evidence and release in some time. |
Thank you for the heads-up. In fact, 1.2.2 is kind of an urgent fix for 1.2.1 (see Issue#160) - this is why I intended to skip 1.2.1 in stable repo. But it is not crucial: the bug/fix does not affect the majority of users, so I expect no big impact when waiting 2 weeks before v1.2.2 is declared "stable". |
Automated adapter checkerioBroker.e3dc-rscp👍 No errors found
Add comment "RE-CHECK!" to start check anew |
Thanks for fixing the adapter checker issues so fast. I would ask to fix two other problems:
Please add the sentry info to README.md. See other adapters if you need more info.
Note that the warnings reported by re-check (#2310 (comment)) can be ignored. Form my side we are done as soon as you add the sentry info and the requested release is active at lasted for some days. Thanks for effort and for maintaining thsi adapter. |
done (master branch). |
I'm afraid I do not really understand what I should do.
How can I (re-)trigger the v1.2.2 release for the stable repo? |
OK, sorry for the typ. The "problem" is that there is a merge conflict currently. I'm not a spcialist with github so I cannot answer hwo to effectly rebase at your side. Sorry. I will fix this during merge - so do not bother further with this detail. For the future - please ensure that thers only ONE open PR for a single adapter in parallel. Thanks for processing my suggestions. |
Many thanks. I rely on you this time and next time, I will do my best to avoid two concurrent PRs. |
1.2.2 25.5. user 52 (5%) sentry has been added to readme.md OK wg. wichtigem Fix |
Please update my adapter ioBroker.e3dc-rscp to version 1.2.2.
This pull request was created by https://www.iobroker.dev c0726ff.