Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Issues reported by Repository checker [#350] #351

Merged

Conversation

mattreim
Copy link
Contributor

@mattreim mattreim commented Aug 9, 2024

@mattreim mattreim changed the title Add/remove common.news Repository checker [#350] Aug 9, 2024
@mcm1957
Copy link
Member

mcm1957 commented Aug 10, 2024

@mattreim
Are you sure that words.js is NOT used by any code part? Might be access from runtime code too - not only from (removed) admin html code. Did you check this?

If deleted adaptions at weblate config are required. Whover merges this PR please consider this and contact me.

@mattreim
Copy link
Contributor Author

You're right. I can't check it properly so I restored it.

@mcm1957 mcm1957 changed the title Repository checker [#350] Fixes for Issues reported by Repository checker [#350] Sep 1, 2024
@mcm1957
Copy link
Member

mcm1957 commented Sep 27, 2024

@mattreim
Did you Test compact mode?
Simply enabling it is not the goal.

@mattreim
Copy link
Contributor Author

Actually it should work with admin5.

@mattreim
Copy link
Contributor Author

I'll delete it again.

@mcm1957
Copy link
Member

mcm1957 commented Sep 27, 2024

Actually it should work with admin5.

Ähhmm
I do not see any reaktion between ADMIN and compact mode. Did you mean js-controller 5?

But there might be a timer which is not cancelled at unload. Thats incompatible with compact mode.

@mattreim
Copy link
Contributor Author

Anything can happen with this old adapter.

@mcm1957 mcm1957 merged commit 986bc14 into iobroker-community-adapters:master Sep 29, 2024
18 checks passed
@mattreim mattreim deleted the Repository-checker-#350] branch October 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants