Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] consider migrating to json config #36

Closed
mcm1957 opened this issue Feb 22, 2023 · 4 comments
Closed

[QA] consider migrating to json config #36

mcm1957 opened this issue Feb 22, 2023 · 4 comments
Labels
Milestone

Comments

@mcm1957
Copy link
Member

mcm1957 commented Feb 22, 2023

If possible - without loosing functionality - the config interface should be migrated to json based config.

@ciddi89
Copy link
Contributor

ciddi89 commented Feb 22, 2023

I was also thinking about it and would change it to jsonConfig if you like

@mcm1957
Copy link
Member Author

mcm1957 commented Feb 22, 2023

Would be ok for me if you have time to do. I've at least 3 other adapters where I can continue :-)
This would also mean migrating to i18n translation system.

I would prefer to use symbolic labels for text (i.e. lblUsername instead of Username inside jsonConfig) as this m akes it more clear if changing english text later in weblate. Please see snmp adapter for details I refer to.

Anyway:
Before committing major changes I would suggest to release an 2.0.0-alpha.x to latest so that it's clear the the migration itself was complete. We should discuss this via telegram. Feel free to contact me at personal telegram or at developer just as you prefer.

@mcm1957 mcm1957 added this to the Release 2.0.x milestone Feb 22, 2023
@ciddi89
Copy link
Contributor

ciddi89 commented Feb 22, 2023

Okay I will make the whole program with translations and jsonConfig and will look what we can migrate so the user will have as less work as possible.

I have open a new branch with my name so I/we can test the changes before I push it in the main branch.

@ciddi89 ciddi89 added in Test and removed QA labels Feb 28, 2023
ciddi89 added a commit that referenced this issue Mar 2, 2023
-   (ciddi89) Dropped: Admin 5 support
-   (ciddi89) Changed: Admin html to jsonConfig [#36](#36)
-   (ciddi89) Fixed: Issue with Midnight function
-   (ciddi89) Added: Translations of admin ui [#28](#28)
-   (ciddi89) Updated: Readme
@ciddi89 ciddi89 closed this as completed Mar 2, 2023
@mcm1957
Copy link
Member Author

mcm1957 commented Mar 3, 2023

Implemented at 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants