Skip to content

Commit

Permalink
Update web player in docs for custom registerComponent names
Browse files Browse the repository at this point in the history
Summary:
In the web player in the docs, allows `AppRegistry.registerComponent('name', App)` to use *anything* for `'name'`. It is ignored by the web player - last registration wins.
Closes facebook#8383

Differential Revision: D3478922

Pulled By: JoelMarcey

fbshipit-source-id: 3d1d96e0ad41216d29134ba384896e86d0cd2b32
  • Loading branch information
dabbott authored and samerce committed Aug 23, 2016
1 parent e8d870f commit 435d9c1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions website/core/WebPlayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ var WebPlayer = React.createClass({
},

render: function() {
var hash = `#code=${encodeURIComponent(this.props.children)}&runApp=AwesomeProject`;
var hash = `#code=${encodeURIComponent(this.props.children)}`;

if (this.props.params) {
hash += `&${this.props.params}`;
Expand All @@ -57,7 +57,7 @@ var WebPlayer = React.createClass({
style={{marginTop: 4}}
width='880'
height={this.parseParams(this.props.params).platform === 'android' ? '425' : '420'}
data-src={`//cdn.rawgit.com/dabbott/react-native-web-player/v0.1.2/index.html${hash}`}
data-src={`//cdn.rawgit.com/dabbott/react-native-web-player/v0.1.3/index.html${hash}`}
frameBorder='0'
/>
</div>
Expand Down

0 comments on commit 435d9c1

Please sign in to comment.