test: cache lazy properties, fix style nits #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'as LOCALHOST or expect some tests to fail.'); | ||
| } | ||
| } else { | ||
| localhostIPv4 = '127.0.0.1'; |
There was a problem hiding this comment.
This will never be reached for FreeBSD jails that hasn't set LOCALHOST. I think falling back to '127.0.0.1' is the right thing here.
|
Sorry for being too quick on the gun in #1167. Minor nit otherwise LGTM. |
rvagg
force-pushed
the
cleanup-freebsd-test-exports
branch
from
f3f6f6d
to
11042de
Compare
|
@jbergstroem ptal, I've changed the logic around the default fallback |
|
(am I the only one that's annoyed by the alignment of the shipit icon?) |
LGTM – thanks again for improving my version.
inFreeBSDJail involves an execSync() and is used by localhost_ipv4 so will be unnecessarily expensive, so cache both values and reuse rather than re-evaluate each time. Renamed localhost_ipv4 to localhostIPv4 for style consistency. PR-URL: nodejs#1196 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
rvagg
force-pushed
the
cleanup-freebsd-test-exports
branch
from
11042de
to
f600111
Compare
|
landed @ f600111 |
This was referenced Apr 24, 2023
This was referenced Apr 26, 2023
This was referenced Apr 27, 2023
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(addressing the concerns I raised too late in #1167)
inFreeBSDJailinvolves anexecSync()and is used bylocalhost_ipv4so will be unnecessarily expensive, so cache both values and reuse rather than re-evaluate each time.Renamed
localhost_ipv4tolocalhostIPv4for style consistency./R=@jbergstroem
/R=@bnoordhuis