Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cache lazy properties, fix style nits #1196

Merged
merged 1 commit into from
Mar 19, 2015
Merged

test: cache lazy properties, fix style nits #1196

merged 1 commit into from
Mar 19, 2015

Commits on Mar 19, 2015

  1. test: cache lazy properties, fix style nits 

    inFreeBSDJail involves an execSync() and is used by localhost_ipv4 so
will be unnecessarily expensive, so cache both values and reuse
rather than re-evaluate each time.

Renamed localhost_ipv4 to localhostIPv4 for style consistency.

PR-URL: nodejs#1196
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    @rvagg
    rvagg committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    f600111 View commit details
    Browse the repository at this point in the history