-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workbox-config.js #885
Conversation
PR Analysis
PR Feedback
How to use
|
@CodiumAI-Agent /describe |
@CodiumAI-Agent /improve |
@CodiumAI-Agent /update_changelog |
@@ -2,7 +2,7 @@ module.exports = { | |||
swDest: 'public/sw.js', | |||
runtimeCaching: [{ | |||
// Match any same-origin request that contains 'api'. | |||
urlPattern: new RegExp('^https\:\/\/gateway.marvel.com\/v1\/public\/.+'), | |||
urlPattern: new RegExp(/https\:\/\/gateway\.marvel\.com\/v1\/public\/.+/g), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The RegExp constructor is not necessary when defining a regular expression. It can be simplified.
urlPattern: new RegExp(/https\:\/\/gateway\.marvel\.com\/v1\/public\/.+/g), | |
urlPattern: /https\:\/\/gateway\.marvel\.com\/v1\/public\/.+/g, |
@@ -19,7 +19,7 @@ | |||
}, | |||
}, | |||
{ | |||
urlPattern: new RegExp('^https://gateway.marvel.com/v1/public/.+'), | |||
urlPattern: new RegExp(/https\:\/\/gateway\.marvel\.com\/v1\/public\/.+/g), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The RegExp constructor is not necessary when defining a regular expression. It can be simplified.
urlPattern: new RegExp(/https\:\/\/gateway\.marvel\.com\/v1\/public\/.+/g), | |
urlPattern: /https\:\/\/gateway\.marvel\.com\/v1\/public\/.+/g, |
Changelog updates: 2023-11-16Fixed
|
Fix issue #882
Fix issue #883