Simplify connection closing #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 82.68% 83.43% +0.75%
==========================================
Files 6 6
Lines 1282 1274 -8
Branches 139 137 -2
==========================================
+ Hits 1060 1063 +3
+ Misses 183 170 -13
- Partials 39 41 +2
Continue to review full report at Codecov.
|
anton-ryzhov
force-pushed
the
simplify-connection-closing
branch
from
fb77087
to
17cb1f2
Compare
|
Well I can't really remember why it was so complicated. I think I wanted to avoid some weird situations where errors wouldn't be able to go anywhere cause there's no valid stderr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this fix #58 it could be much simpler but safe