This repository has been archived by the owner on Aug 3, 2020. It is now read-only.
Apply scoped_as option when eager loading associations #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| query.instance_exec &scope | ||
| end | ||
| end | ||
| apply_scope query |
There was a problem hiding this comment.
This is within a define_method block, which is adding to the API of @parent. I don't think you will have access to apply_scope when the dynamically defined method is invoked.
|
@bradstewart can we start with a failing test that reproduces your problem? I think I've seen what you're describing before, so I'm certainly interested in finding the root cause. |
|
@DanOlson Yep you were right, sorry about that. I wasn't paying attention when I quickly made that method. Will figure out a better way to reuse the code at some point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
:scoped_asoptions onHasManyAssociations wasn't being applied when eager loading with:includes, so I took a quick stab at fixing it.I wasn't entirely sure when
ActiveQueryshould be used as opposed toQuery, so let me know if these changes might cause any unintended problems. I will update the specs soon if you like these changes.