Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Generator fix #108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

DServy
Copy link

@DServy DServy commented Nov 2, 2015

Fix for #107

Added google docs to standard types
Currently creates file name and camel case class names
@olvap
Copy link
Contributor

olvap commented Nov 2, 2015

Seems ok te me. @eloyesp what do you think?

@eloyesp
Copy link
Contributor

eloyesp commented Nov 2, 2015

👍

Accidentally did the wrong fix. This is the proper fix
@DServy
Copy link
Author

DServy commented Nov 2, 2015

@olvap and @eloyesp pushed the wrong fix that doesn't solve all use cases. Just pushed up the proper fix. Please review and let me know what you think!

@eloyesp
Copy link
Contributor

eloyesp commented Nov 3, 2015

Can we add some tests for the generator?

--- Eloy

2015-11-02 19:22 GMT-03:00 David Staley notifications@github.com:

@olvap https://github.com/olvap and @eloyesp
https://github.com/eloyesp pushed the wrong fix that doesn't solve all
use cases. Just pushed up the proper fix. Please review and let me know
what you think!


Reply to this email directly or view it on GitHub
#108 (comment)
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants