Wrap callbackFromNative in Promise.resolve #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem I’ll test it out with a couple of projects next week when I am back in the office. |
jcesarmobile
force-pushed
the
callbackFromNative-promise
branch
from
609ba27
to
5206c50
Compare
|
@jcesarmobile this is all working fine for me, have updated 2 projects with no issues encountered so far. |
|
thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As on #124 the setTimeout was removed, it could cause problems (none reported at the moment, but you never know).
This should protect from those possible problems as it keeps the behaviour the setTimeout used to have (putting the code into a the queue for the next process tick).
@ghenry22 can you test this and see if keeps working fine in background?
See related cordova-plugin-wkwebview-engine PR