-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server doesn't start with latest Ionic CLI #3473
Comments
Was this not happening in Ionic CLI 4.0.2? |
Confirmed! Works as expected in 4.0.2 @dwieeb |
Getting similar behavior on Ionic4/Capacitor project on Windows 10. The "ionic serve" command results in this message being repeated in the console The "ionic serve" command successfully displays app in version Ionic 4.0.2 $ ionic info
|
@dwieeb mumumu...It is a guess
if worked @CheetahDev @matthew-valenti |
@rdlabo Maybe we should use |
@amanitequeen If you're still around, would you mind copy/pasting the contents of the following file: |
@dwieeb It may be good to check the dns. If
|
Agreed, I think we'll need some sort of check just like that. |
Although, @rdlabo The dns lookup shouldn't be necessary, as the NodeJS internals will do that. I think just the if-statement: if (host === '0.0.0.0' && typeof address === 'undefined') {
host = '127.0.0.1';
} |
@dwieeb |
We are talking about the host used for the changes introduced in this PR: https://github.com/ionic-team/ionic-cli/pull/3444/files Here is what I'm thinking: const host = options.address === '0.0.0.0' ? '127.0.0.1' : options.address;
await isHostConnectable(host, port); |
The default serve address should not be |
Sure, I see. I will make pull request. Maybe this is change in network.ts. |
Hello !
|
Hi @rdlabo,
✔️ ❌ ✔️ Regards |
@amanitequeen thanks! ( in Japan, Now is the evening) and please try |
@CheetahDev Sure, Ionic CLI don't use 0.0.0.0 in your env. but can use 127.0.0.1. thanks!! |
@amanitequeen Thank you! Hmm, the file looks fine. Won't matter, because I think we'll be using |
Description:
Server doesn't start after upgrading to the latest version of Ionic CLI (Ionic v1 project)
Steps to Reproduce:
npm install -g ionic
ionic start testv1 sidemenu --type=ionic1
cd testv1
ionic serve --verbose
Output (from the bellow steps):
Output (from our project):
My
ionic info
:Other Information:
package.json (from steps to reproduce)
@ionic/v1-toolkit is v1.0.0 by default (same issue), upgrade to 1.0.2 doesn't work either.
The text was updated successfully, but these errors were encountered: