Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli-utils/project): pass the host address as it is #3444

Merged
merged 2 commits into from
Jul 31, 2018
Merged

fix(cli-utils/project): pass the host address as it is #3444

merged 2 commits into from
Jul 31, 2018

Conversation

rdlabo
Copy link
Contributor

@rdlabo rdlabo commented Jul 31, 2018 •
edited
Loading

Fixes #3410

Change await isHostConnectable('localhost', port); to await isHostConnectable(options.address, port); . I think this is consistent findOpenIonicPorts()'s address.

@rdlabo rdlabo requested a review from imhoffd as a code owner July 31, 2018 03:51
@rdlabo rdlabo mentioned this pull request Jul 31, 2018
Closed
@rdlabo rdlabo changed the title fix(cli-framework/network): change localhost 0.0.0.0 WIP: fix(cli-framework/network): check 'localhost' resolved. Jul 31, 2018
@rdlabo rdlabo force-pushed the change_localhost branch from a8f59f9 to 2e042db Compare July 31, 2018 05:15
@rdlabo rdlabo changed the title WIP: fix(cli-framework/network): check 'localhost' resolved. fix(cli-framework/network): check 'localhost' resolved. Jul 31, 2018
@rdlabo rdlabo force-pushed the change_localhost branch from c38daf5 to e10416a Compare July 31, 2018 05:52
@rdlabo rdlabo changed the title fix(cli-framework/network): check 'localhost' resolved. fix(cli-utils/project): pass the host address as it is Jul 31, 2018
@HugoHeneault HugoHeneault mentioned this pull request Jul 31, 2018
Closed
@imhoffd imhoffd merged commit bf10674 into ionic-team:develop Jul 31, 2018
@imhoffd
Copy link
Contributor

imhoffd commented Jul 31, 2018 •
edited
Loading

This looks great. I also have some additional changes related to how the Ionic CLI chooses a port.

EDIT: @rdlabo 👉 30fd6ef

These changes will make sure it finds an open port no matter which address is used.

@rdlabo rdlabo deleted the change_localhost branch August 1, 2018 01:54
@rdlabo
Copy link
Contributor Author

rdlabo commented Aug 2, 2018

checking for open port is great!! thanks!!

@imhoffd imhoffd mentioned this pull request Aug 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imhoffd imhoffd imhoffd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[INFO] Waiting for connectivity with ionic-app-scripts...
2 participants
@rdlabo @imhoffd