fix(serve): await connectivity on specified host, not localhost (#3444)

ionic-team · Jul 31, 2018 · bf10674 · bf10674
1 parent f767bfb
commit bf10674
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/@ionic/cli-utils/src/lib/project/angular/serve.ts b/packages/@ionic/cli-utils/src/lib/project/angular/serve.ts
@@ -104,7 +104,7 @@ ${chalk.cyan('[1]')}: ${chalk.bold('https://github.com/angular/angular-cli/wiki/
       this.e.log.info(`Waiting for connectivity with ${chalk.green(program)}...`);
     }, 5000);
 
-    await isHostConnectable('localhost', ngPort);
+    await isHostConnectable(options.address, ngPort);
     clearInterval(interval);
 
     return {

diff --git a/packages/@ionic/cli-utils/src/lib/project/ionic-angular/serve.ts b/packages/@ionic/cli-utils/src/lib/project/ionic-angular/serve.ts
@@ -126,7 +126,7 @@ export class IonicAngularServeRunner extends ServeRunner<IonicAngularServeOption
       this.e.log.info(`Waiting for connectivity with ${chalk.green(program)}...`);
     }, 5000);
 
-    await isHostConnectable('localhost', port);
+    await isHostConnectable(options.address, port);
     clearInterval(interval);
 
     return {

diff --git a/packages/@ionic/cli-utils/src/lib/project/ionic1/serve.ts b/packages/@ionic/cli-utils/src/lib/project/ionic1/serve.ts
@@ -105,7 +105,7 @@ export class Ionic1ServeRunner extends ServeRunner<Ionic1ServeOptions> {
       this.e.log.info(`Waiting for connectivity with ${chalk.green(program)}...`);
     }, 5000);
 
-    await isHostConnectable('localhost', port);
+    await isHostConnectable(options.address, port);
     clearInterval(interval);
 
     return {