Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playground): add support for generating a new playground #2994
feat(playground): add support for generating a new playground #2994
Changes from 16 commits
e14eb22
61e5dc3
62003d8
af3ab6b
e648bc5
9fe4970
7f892c4
e550592
bce58e7
0c56e30
94e0d5d
be0ce65
b886304
a322b38
9905e53
be300d2
e02db6e
9aa8d83
5c37cb7
7bb71b3
f04be20
705002b
8e9df52
e96c425
ffc5df3
4c041cb
eaf5fd1
ecc4d1a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally optional, but it might be cool if the command could spit out this code for you to copy-paste, dynamically using the (formatted) name of the innermost directory created as the feature name. Don't worry about it if it would be a big lift, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!! There's probably a more elegant way we could do it, but I added an MVP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this with a little improvement, although it still would be better if it only gets logged if the files are successfully generated. (But at least now the copy doesn't state that the generation succeeded.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps there's a way to do this without using relative paths? I couldn't quickly find one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very open to copy changes for the prompts in this file. I just put the first thing that came to mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a note that the component name must be kebab case? For example writing "IonButton" won't work as expected