Skip to content

Commit

Permalink
fix(item): router-link remains clickable with item cover (#29743)
Browse files Browse the repository at this point in the history
Issue number: N/A

---------

## What is the current behavior?
Item includes `ion-anchor` in the list of clickable components it
queries. This component was renamed to `ion-router-link` in
[v5](https://github.com/ionic-team/ionic-framework/blob/main/BREAKING_ARCHIVE/v5.md#anchor).

## What is the new behavior?
Updates the reference to `ion-anchor` to `ion-router-link` in
`ion-item`.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No
  • Loading branch information
brandyscarney authored Aug 5, 2024
1 parent bfee3cd commit a9f278a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/src/components/item/item.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export class Item implements ComponentInterface, AnchorInterface, ButtonInterfac
);

// The following elements should also stay clickable when an input with cover is present
const clickables = this.el.querySelectorAll('ion-anchor, ion-button, a, button');
const clickables = this.el.querySelectorAll('ion-router-link, ion-button, a, button');

// Check for multiple inputs to change the position of the input cover to relative
// for all of the covered inputs above
Expand Down

0 comments on commit a9f278a

Please sign in to comment.