Skip to content

Commit

Permalink
test(angular): add timeout to avoid flaky value accessor test (#25522)
Browse files Browse the repository at this point in the history
  • Loading branch information
sean-perkins authored Jun 24, 2022
1 parent f5eec13 commit b3c0528
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions angular/test/test-app/e2e/src/form.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ describe('Form', () => {
cy.get('ion-input.required').invoke('prop', 'value', 'Some value');
testStatus('INVALID');

// TODO: FW-1160 - Remove when v7 is released
cy.wait(300);

cy.get('ion-select').invoke('prop', 'value', 'nes');
testStatus('INVALID');

Expand Down
1 change: 1 addition & 0 deletions core/src/components/select/select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ export class Select implements ComponentInterface {
@Watch('value')
valueChanged() {
this.emitStyle();
// TODO: FW-1160 - Remove the `didInit` property when ionChange behavior is changed in v7.
if (this.didInit) {
this.ionChange.emit({
value: this.value,
Expand Down

0 comments on commit b3c0528

Please sign in to comment.