Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ionic v4] ion-item-option doesn't get style class activated when clicked #14943

Closed
peterpeterparker opened this issue Jul 30, 2018 · 3 comments
Assignees

Comments

@peterpeterparker
Copy link
Contributor

Ionic Info
@ionic/angular: "4.0.0-beta.0"

Describe the Bug
When I click an ion-item-sliding > ion-item-options > ion-item-option the item doesn't get the style class activated (as in v3) in order to display the user that is click was effectively detected

Related Code

As in the breaking change doc

<ion-item-sliding>
<ion-item>
  <ion-label>Slide and click, not activated</ion-label>
</ion-item>
<ion-item-options side="end">
  <ion-item-option expandable (click)="clickSlideItem()">
    <ion-icon name="star"></ion-icon>
  </ion-item-option>
</ion-item-options>

or

git clone https://github.com/peterpeterparker/ion-title-component

Expected Behavior
Add style class activated when sliding items are clicked / activated

@ionitron-bot ionitron-bot bot added the triage label Jul 30, 2018
@peterpeterparker peterpeterparker changed the title [Ionic v4] ion-item-option doesn't get class activated when clicked [Ionic v4] ion-item-option doesn't get style class activated when clicked Jul 30, 2018
@ionitron-bot ionitron-bot bot removed the triage label Sep 14, 2018
@brandyscarney
Copy link
Member

I added the ripple and activated class, @camwiegert could you make sure the style is right for activated when you work on converting away from --ion-color vars?

@erperejildo
Copy link

shouldn't it be with icon-only?

https://beta.ionicframework.com/docs/api/item-sliding

@ionitron-bot
Copy link

ionitron-bot bot commented Oct 23, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants