Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: The clear button of ion-input remains gray #19178

Closed
SidiBecker opened this issue Aug 25, 2019 · 6 comments · Fixed by #26354
Closed

bug: The clear button of ion-input remains gray #19178

SidiBecker opened this issue Aug 25, 2019 · 6 comments · Fixed by #26354
Labels
help wanted a good issue for the community package: core @ionic/core package type: bug a confirmed bug report

Comments

@SidiBecker
Copy link

Bug Report

Ionic version:
[x] 4.8.0

Current behavior:
The clear button color remains gray

Expected behavior:
The clear button color must match the color set

Steps to reproduce:

ionic start

Put <ion-input clearInput value="clear me"></ion-input> on HTML

Set color on app.scss:

:root{ 
      --ion-color-step-600: red;
 }

Related code:

Screenshot of bug

Ionic info:

   Ionic CLI                     : 5.1.0 (C:\Users\sidi\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.8.0
   @angular-devkit/build-angular : 0.13.9
   @angular-devkit/schematics    : 7.3.9
   @angular/cli                  : 7.3.9
   @ionic/angular-toolkit        : 1.5.1

Cordova:

   Cordova CLI       : not installed
   Cordova Platforms : not available
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.1.0, (and 6 other plugins)

Utility:

   cordova-res : not installed
   native-run  : 0.2.6

System:

   NodeJS : v10.16.0 (C:\Program Files\nodejs\node.exe)
   npm    : 6.9.0
   OS     : Windows 10
@ionitron-bot ionitron-bot bot added the triage label Aug 25, 2019
@jakubnovak998
Copy link

Hi,
The color remains gray because you didn't assign the color to any of ion-input's custom properties https://ionicframework.com/docs/api/input#css-custom-properties

@SidiBecker
Copy link
Author

SidiBecker commented Aug 26, 2019

Hi,
The color remains gray because you didn't assign the color to any of ion-input's custom properties https://ionicframework.com/docs/api/input#css-custom-properties

Hi @jakubnovak998,
I set --color: white; and --placeholder-color: white; on ion-input, but the color remains gray

@SidiBecker
Copy link
Author

SidiBecker commented Aug 31, 2019

@brandyscarney brandyscarney added help wanted a good issue for the community package: core @ionic/core package type: bug a confirmed bug report labels Jan 26, 2020
@ionitron-bot
Copy link

ionitron-bot bot commented Jan 26, 2020

This issue has been labeled as help wanted. This label is added to issues that we believe would be good for contributors.

If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.

For a guide on how to create a pull request and test this project locally to see your changes, see our contributing documentation.

Thank you!

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #26354, and a fix will be available in an upcoming release of Ionic Framework.

liamdebeasi added a commit that referenced this issue Nov 23, 2022
resolves #19178, resolves #17168

Co-authored-by: Mathieu-COSYNS <Mathieu-COSYNS@users.noreply.github.com>
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 23, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted a good issue for the community package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants