-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: IonTabButton doesn't have default HTML event attributes typed #29174
bug: IonTabButton doesn't have default HTML event attributes typed #29174
Comments
Thank you for submitting the issue! I was able to replicate it. I verified that |
missing HTML types closes ionic-team#29174
Issue number: resolves #29174 --------- ## What is the current behavior? React throws tab errors with `IonTabButton` when binding to `onPointerDown`, `onTouchEnd` and `onTouchMove` ## What is the new behavior? - Adds missing type definitions for `onPointerDown`, `onTouchEnd` and `onTouchMove` to `IonTaButton` - React does not throw type errors when binding callback functions to these events --------- ## Does this introduce a breaking change? - [ ] Yes - [x] No --------- Co-authored-by: steven <sribeiro@gio.lu>
Thanks for the issue! This has been resolved via PR #29736 and will be available in an upcoming release of Ionic. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prerequisites
Ionic Framework Version
v7.x
Current Behavior
IonTabButton is missing regular HTML types (onPointerDown, onTouchEnd, onTouchMove, etc)
Expected Behavior
Should have proper types.
Steps to Reproduce
Try to add
onPointerDown
toIonTabButton
in React. Typescript will complain, but the touch end handler will be properly connected/called.Code Reproduction URL
https://stackblitz.com/edit/wl7fhb-xaawyq?file=src%2Fmain.tsx
Ionic Info
N/A - stackblitz
Additional Information
No response
The text was updated successfully, but these errors were encountered: