bug: Breaking of react types with ionic elements #29755
Labels
Comments
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 20, 2024
Issue number: resolves #29755 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Types do not generate when a React app is opened in IntelliJ IDE. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updated `stencil/react-output-target` to the latest - Updated the stencil config file - Updated `jest`, `ts-jest`, and `typescript` because of the changes in `packages/react/tsconfig.json` - Installed `jest-environment-jsdom` because Jest 26 no longer ships it by default since the test environment is now node by default. The test environment needs to be changed to `jsdom` when [building a web app](https://jestjs.io/docs/configuration#testenvironment-string).   ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> No visual changes are introduced and there will be no changes needed by developers. Their apps will continue to work as is. ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: 8.2.8-dev.11724100788.103018f2
|
This issue was fixed in v8.2.8! Please update to the latest version to receive the fix. |
|
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Prerequisites
Ionic Framework Version
v8.x
Current Behavior
IN INTELLIJ
In React 8, the types do not generate for Ion Elements
Expected Behavior
The type to not be unknown, and have type interface help while coding.
Steps to Reproduce
IDE:INTELLIJ
1.ionic start myapp --type=react
2. Add <Ion${anything ionic element}>
3. Hover
Code Reproduction URL
https://github.com/ionic-team/starters/tree/main/react/official/blank
Ionic Info
Ionic:
Ionic CLI : 7.2.0 (/opt/homebrew/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/react 8.2.6
Capacitor:
Capacitor CLI : 6.1.1
@capacitor/android : 6.1.1
@capacitor/core : 6.1.1
@capacitor/ios : 6.1.1
Utility:
cordova-res : not installed globally
native-run : 2.0.1
System:
NodeJS : v21.7.2 (/opt/homebrew/Cellar/node/21.7.2/bin/node)
npm : 10.5.0
OS : macOS Unknown
Additional Information
No response
The text was updated successfully, but these errors were encountered: