-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ion-item-divider color has no effect #8376
Comments
I am also having same issue. Here is the information: Your system information: Cordova CLI: 6.3.1 |
I am also having the same issue. Your system information: Cordova CLI: 6.3.1 |
@brandyscarney seems like some css issue. Can you please suggest a workaround in rc0? Can I override some css to show divider color in popover, at least some color? |
You could use inline styling as a temporary solution.
For the other components you can use The reason for the second workaround can be found here: #8330 (comment) |
As a temporary workaround you can add the following Sass to the
|
@brandyscarney it worked on page but didn't work in popover. Right now I'm using workaround suggested by @NickStemerdink by adding Can you please test it works in popover as well before releasing rc.1? 👍 |
I have the same issue. |
It may be what is expected for the platform but on android ion-item-divider Color is never applied whether you use it just in a normal page or in another element like a popover. |
The same issue is true for the
The header background color should change |
- adds ItemDivider class to add color and mode css classes to item divider - adds e2e test for item divider colors - adds sass variables to improve control over list headers and item divider styles - fixes style for item divider so it will be styled regardless of being inside a list for md and wp modes references #8376
…nt and item - change the default text color and background color to match the theme variables. This makes popover look better on dark theme and removes the nesting of styles that breaks list headers. fixes #8376
* fix(item): fix color input for item divider and list header - adds ItemDivider class to add color and mode css classes to item divider - adds e2e test for item divider colors - adds sass variables to improve control over list headers and item divider styles - fixes style for item divider so it will be styled regardless of being inside a list for md and wp modes references #8376 * refactor(popover): remove the background color styling from ion-content and item - change the default text color and background color to match the theme variables. This makes popover look better on dark theme and removes the nesting of styles that breaks list headers. fixes #8376
This should be fixed now, I released a nightly version of the framework
Thanks! |
It works with the nightly version. Thanks! |
I have same issue with 2.1.8 |
I had the same issue with 2.1.8. I did the npm install of the nightly version that @brandyscarney requested and now the ion-item-divider is properly colored with the "color="secondary"' attribute. Oddly enough I had a lot of install errors upon running the command but somehow it still works lol |
Hey there,
|
@brandyscarney ohh that's right lol thank you for making me aware of that. just ran ionic info and I can confirm that i have 2.0.0-rc.3. Thanks again :) |
Short description of the problem:
Setting color attribute on ion-item-divider has no effect. On page, it shows default light color and in Popover it doesn't even show light color. It was working perfectly in beta 11.
What behavior are you expecting?
Setting color should change divider color
Steps to reproduce:
Please see this commit to reproduce https://github.com/aggarwalankush/ionic-inappbrowser-issue/commit/46d3e553c0e099771530cce3d533dce374ec7cbd
Just primary or color="primary", no change in color
Which Ionic Version? 1.x or 2.x
Ionic 2 rc0
Run
ionic info
from terminal/cmd prompt: (paste output below)Your system information:
Cordova CLI: 6.3.1
Ionic CLI Version: 2.1.0
Ionic App Lib Version: 2.1.0-beta.1
ios-deploy version: 1.9.0
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v6.7.0
Xcode version: Xcode 8.0 Build version 8A218a
The text was updated successfully, but these errors were encountered: