Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): Fix --multi-app support for ng-add schematic #20768

Merged
merged 5 commits into from
Mar 18, 2020
Merged

fix(angular): Fix --multi-app support for ng-add schematic #20768

merged 5 commits into from
Mar 18, 2020

Conversation

SchnWalter
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Ionic CLI added a new "--multi-app" option for working with mono-repositories in ionic-team/ionic-cli@42c5199, this includes improved support for updating Angular CLI workspaces by using

ng add @ionic/angular --project=demo-project

This behavior is documented in the new Angular-Monorepo wiki page; but the generated angular.json file is not valid because some schematic code always uses app as the project name.

To reproduce the issue, just follow the steps described in the Angular-Monorepo wiki page, but don't use app as the default project name, use mobile or whatever you prefer.

This MR is related to one of the issues for which the new flag was introduced: ionic-team/ionic-cli#4192

What is the new behavior?

The --project=... argument is now respected by the ng add schematic.

Does this introduce a breaking change?

  • Yes
  • No

cc: @dwieeb

@mhartington mhartington merged commit 39e6c8f into ionic-team:master Mar 18, 2020
@SchnWalter SchnWalter deleted the fix-add-ionic-builder branch March 18, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants