test(item): migrate tests to playwright #25479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
commented
Jun 15, 2022
liamdebeasi
approved these changes
Jun 15, 2022
| @@ -27,7 +27,7 @@ | |||
| <ion-list-header>Leading Icons</ion-list-header> | |||
| <ion-item> | |||
| <ion-icon slot="start" name="time"></ion-icon> | |||
| <ion-datetime display-format="DDDD MMMM D YYYY hh:mm:ss a" value="2019-10-01T15:43:40.394Z"></ion-datetime> | |||
| <ion-datetime value="2019-10-01T15:43:40.394Z"></ion-datetime> | |||
There was a problem hiding this comment.
Do we need to use ion-datetime here? Wondering if we can use something else instead to make the screenshots a bit smaller
There was a problem hiding this comment.
I don't believe so, I can swap those out with inputs 👍
averyjohnston
suggested changes
Jun 15, 2022
|
|
||
| await page.setIonViewport(); | ||
|
|
||
| await page.click('text=Edit'); |
There was a problem hiding this comment.
~ Might be better to use a more stable selector, like an ID.
13 tasks
averyjohnston
suggested changes
Jun 28, 2022
| import { test } from '@utils/test/playwright'; | ||
|
|
||
| test.describe('item: inputs', () => { | ||
| test('should not have visual regressions', async ({ page }) => { |
There was a problem hiding this comment.
At least one of the datetimes is missing entirely here:
core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Firefox-linux.pngcore/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Safari-linux.pngcore/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Safari-linux.png
You may need to do await page.waitForSelector('.datetime-ready')?
averyjohnston
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Item tests are written in Puppeteer.
Issue URL: N/A
What is the new behavior?
Migrates tests to Playwright
setIonViewportthat allows resizing the horizontal size of the viewport to match the scroll contents (for niche tests like the form test for item).Does this introduce a breaking change?
Other information