Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(action-sheet): migrate to playwright #25523

Merged
merged 16 commits into from
Jun 24, 2022
Merged

test(action-sheet): migrate to playwright #25523

merged 16 commits into from
Jun 24, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL:

What is the new behavior?

  • All the spec test did was open an action sheet, screenshot it, then dismiss it. The action sheet had a bunch of icons in it. This same test is done in should open basic action sheet, so I deleted the spec directory.
  • Same thing with the icons tests -- the basic action sheet already has icons in it + screenshots.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi
Copy link
Contributor Author

liamdebeasi commented Jun 22, 2022

Linux seems to have some trouble rendering the translucent blur in Safari -- it works for me locally and on an actual iOS device. I can make a ticket, but I'm not sure how much we'd be able to "fix" here.

@liamdebeasi liamdebeasi marked this pull request as ready for review June 22, 2022 20:57
@liamdebeasi liamdebeasi requested a review from a team as a code owner June 22, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants