Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(datetime): resolve flaky tests as year changes #26561

Merged
merged 5 commits into from
Jan 4, 2023
Merged

test(datetime): resolve flaky tests as year changes #26561

merged 5 commits into from
Jan 4, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 4, 2023 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Certain datetime tests are failing due to the year/month changing: https://github.com/ionic-team/ionic-framework/actions/runs/3833153770

What is the new behavior?

  • Affected tests either set a max or mock the date so they do not fail every time the year changes.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the title Test 2023 test(datetime): tests are no longer year dependent Jan 4, 2023
@github-actions github-actions bot added the package: core @ionic/core package label Jan 4, 2023
@liamdebeasi liamdebeasi changed the title test(datetime): tests are no longer year dependent test(datetime): resolve flaky tests as year changes Jan 4, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review January 4, 2023 14:28
@liamdebeasi liamdebeasi requested a review from a team as a code owner January 4, 2023 14:28
@liamdebeasi liamdebeasi merged commit 1917c71 into main Jan 4, 2023
@liamdebeasi liamdebeasi deleted the test-2023 branch January 4, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liamdebeasi