Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): add updated snapshots #27651

Closed
wants to merge 6 commits into from
Closed

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jun 14, 2023

Adds screenshots for #27641

@stackblitz
Copy link

stackblitz bot commented Jun 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@brandyscarney brandyscarney changed the base branch from feature-7.1 to FW-1593 June 14, 2023 19:45
@github-actions github-actions bot added the package: core @ionic/core package label Jun 14, 2023
@brandyscarney brandyscarney marked this pull request as ready for review June 14, 2023 20:56
@liamdebeasi
Copy link
Contributor

Have you considered placing all of the circle styles on .calendar-day-highlight instead of removing it entirely? I think part of the problem is each button is a column in the grid. The grid columns expand as the datetime expands in width, but the visible circle shouldn't change in size.

I made a sample on https://github.com/ionic-team/ionic-framework/tree/1593-alt. I was able to keep the dimensions for the MD datetime pretty similar. iOS is close, but the button height is wrong (I didn't have time to figure that part out, but I will if I have time this week).

@brandyscarney brandyscarney marked this pull request as draft June 20, 2023 19:31
@brandyscarney brandyscarney deleted the 1593-screenshots branch July 17, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants