Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colors): override element styling and tweak colors for card and item #9118

Merged
merged 4 commits into from
Nov 11, 2016

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Nov 10, 2016

  • Refactor card to add color/mode classes to header, title, content
  • Generate colors for the card itself, the header, the content, and the
    title using the color input
  • Adds e2e test for card colors
  • Refactor item to override paragraph color in item w/ color, update activated colors
  • Adds e2e test for item colors

Closes #9081 Closes #8330

Snapshot for these changes: http://ionic-snapshot-go.appspot.com/ionic2/snapshots/s2n/tdu/chrome_400x800#db69ffb2

What this PR does NOT do:

  • It does not style buttons in items or cards with the color input, we can discuss this but it would end up getting messy real quick if we change the default button colors in cards/items with a color. Therefore if a user makes an item primary they will need to give the button a color because it will default to primary.

- Remove native HTML element styling inside of cards (headings,
paragraph)
- Move the default color for the HTML elements to the content
- Generate colors for the card itself, the header, the content, and the
title using the color input
- Add e2e test for card colors

References #8330
- Adds test for item colors
- Removes the color from native paragraph elements allowing colors to
be passed

Closes #9081
@brandyscarney brandyscarney changed the title fix(colors): remove nested element styling and tweak colors for card and item fix(colors): override element styling and tweak colors for card and item Nov 11, 2016
@adamdbradley adamdbradley merged commit ee3decc into master Nov 11, 2016
@brandyscarney brandyscarney deleted the refactor-card-item-colors branch November 14, 2016 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants