-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(file): alternate file implementation #283
Conversation
alternate file implementation redux
SocialSharing: Add recommended `shareWithOptions` method
Revert "SocialSharing: Add recommended `shareWithOptions` method"
It would be appreciated if someone can give this a quick test, here's an npm package build ready to use: |
I'll try and give it a test this week |
Do I need to do something to address the conflict warning? |
I'll fix the conflict. I was wondering, do all the functions in this implementation work a 100%? If so I will just merge it without testing it personally. |
Sorry, I have not tested every single function, because I don't have client code that uses all of them. |
export * from './plugins/facebook'; | ||
>>>>>>> master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ihadeed, looks like some git merge issues in this file.
Thanks,
Dan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danbucholtz Already fixed!
@ihadeed, you rock! 💯 |
I can see the different directory constants (cacheDirectory etc) are in there which is great. But I can't figure out how to access them! Can you post an example of a simple "check if file exists" or similar? Edit: never mind, I guess the directory constants never made it into master. Would still love to see an example as my old code no longer works with this version. |
This is an alternative file implementation, written by @rapropos
closes #264
closes #254
closes #233
closes #159
closes #123