Setup linter

package.json

@@ -14,7 +14,13 @@
     "dev": "stencil build --es5 --dev --watch --serve --no-open --debug",
     "deploy": "np",
     "start": "npm run dev",
-    "test": "jest"
+    "test": "jest",
+    "lint": "tslint --config tslint.json --project tsconfig.json"
+  },
+  "husky": {
+    "hooks": {
+      "pre-commit": "npm run lint"
+    }
   },
   "repository": {
     "type": "git",
@@ -23,9 +29,13 @@
   "devDependencies": {
     "@stencil/core": "^0.18.0",
     "@types/jest": "^24.0.5",
+    "husky": "^1.3.1",
     "jest": "^24.1.0",
     "np": "^4.0.2",
-    "ts-jest": "^23.10.5"
+    "redux": "^4.0.1",
+    "ts-jest": "^23.10.5",
+    "tslint": "^5.12.1",
+    "tslint-ionic-rules": "0.0.21"
   },
   "peerDependencies": {
     "redux": "^4.0.1"

src/global/interfaces.ts

@@ -1,11 +1,11 @@
 export interface Store {
   dispatch: (action: any, _: any) => any;
-  subscribe: (cb: Function) => any;
+  subscribe: (cb: (...args: any[]) => any) => any;
   getState: () => any;
   getStore: () => any;
-  setStore: (any: any) => void;
+  setStore: (store: any) => void;
   mapStateToProps: (component: any, props: any) => () => void;
   mapDispatchToProps: (component: any, props: any) => void;
-};
+}
 
-export type Action = Function;
+export type Action = (...args: any[]) => any;

src/global/store.ts

@@ -2,38 +2,38 @@ import { Store } from './interfaces';
 
 declare var Context: any;
 
-Context.store = (function() {
+Context.store = (() => {
   let _store: Store;
 
-  function setStore(store: Store) {
+  const setStore = (store: Store) => {
     _store = store;
-  }
+  };
 
-  function getState() {
+  const getState = () => {
     return _store && _store.getState();
-  }
+  };
 
-  function getStore() {
+  const getStore = () => {
     return _store;
-  }
+  };
 
-  function mapDispatchToProps(component: any, props: any) {
+  const mapDispatchToProps = (component: any, props: any) => {
     Object.keys(props).forEach(actionName => {
       const action = props[actionName];
       Object.defineProperty(component, actionName, {
         get: () => (...args: any[]) => _store.dispatch(action(...args), _store),
         configurable: true,
-        enumerable: true
-      })
+        enumerable: true,
+      });
     });
-  }
+  };
 
-  function mapStateToProps(component: any, mapState: Function) {
+  const mapStateToProps = (component: any, mapState: (...args: any[]) => any) => {
     // TODO: Don't listen for each component
     const _mapStateToProps = (_component: any, _mapState: any) => {
       const mergeProps = mapState(_store.getState());
       Object.keys(mergeProps).forEach(newPropName => {
-        let newPropValue = mergeProps[newPropName];
+        const newPropValue = mergeProps[newPropName];
         component[newPropName] = newPropValue;
         // TODO: can we define new props and still have change detection work?
       });
@@ -44,13 +44,13 @@ Context.store = (function() {
     _mapStateToProps(component, mapState);
 
     return unsubscribe;
-  }
+  };
 
   return {
     getStore,
     setStore,
     getState,
     mapDispatchToProps,
-    mapStateToProps
+    mapStateToProps,
   } as Store;
 })();

tslint.json

@@ -1,11 +1,3 @@
 {
-  "rules": {
-    "semicolon": [true, "always"],
-    "curly": [true],
-    "quotemark": [true, "single", "jsx-double"],
-    "no-duplicate-variable": true,
-    "no-unused-variable": [
-      true
-    ]
-  }
+  "extends": "tslint-ionic-rules/strict"
 }