fix(compiler): Allow OutputTargetCustom to be called on devMode

[Sukaato]

What is the current behavior?

GitHub Issue Number: #5514

What is the new behavior?

In this PR, I've added logic so that OutputTargetCustom can be called in dev mode and not just during build.
OutputTargetCustom can choose when it runs by adding a task property to the declaration object.

Documentation

Does this introduce a breaking change?

• Yes
• No

Testing

Run stencil tests + manual test with npm link

Other information

[github-actions]

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/8941330676/artifacts/1471082082

If your browser saves files to ~/Downloads you can install it like so:

unzip -d ~/Downloads ~/Downloads/stencil-core-4.17.2-dev.1714750248.e721546.tgz.zip && npm install ~/Downloads/stencil-core-4.17.2-dev.1714750248.e721546.tgz

[github-actions]

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1138 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files

Path	Error Count
src/dev-server/index.ts	37
src/dev-server/server-process.ts	32
src/compiler/prerender/prerender-main.ts	22
src/runtime/client-hydrate.ts	20
src/testing/puppeteer/puppeteer-element.ts	20
src/screenshot/connector-base.ts	19
src/runtime/vdom/vdom-render.ts	17
src/dev-server/request-handler.ts	15
src/compiler/prerender/prerender-optimize.ts	14
src/compiler/sys/stencil-sys.ts	14
src/sys/node/node-sys.ts	14
src/compiler/prerender/prerender-queue.ts	13
src/compiler/sys/in-memory-fs.ts	13
src/runtime/connected-callback.ts	13
src/runtime/set-value.ts	13
src/compiler/output-targets/output-www.ts	12
src/compiler/transformers/test/parse-vdom.spec.ts	12
src/compiler/transformers/transform-utils.ts	12
src/compiler/transpile/transpile-module.ts	12
src/mock-doc/test/attribute.spec.ts	12

Our most common errors

Typescript Error Code	Count
TS2322	361
TS2345	344
TS18048	205
TS18047	82
TS2722	37
TS2532	24
TS2531	21
TS2454	14
TS2790	11
TS2352	9
TS2769	8
TS2538	8
TS2416	7
TS2493	3
TS18046	2
TS2684	1
TS2430	1

Unused exports report

There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports

File	Line	Identifier
src/runtime/bootstrap-lazy.ts	21	setNonce
src/screenshot/screenshot-fs.ts	18	readScreenshotData
src/testing/testing-utils.ts	198	withSilentWarn
src/utils/index.ts	145	CUSTOM
src/utils/index.ts	245	NODE_TYPES
src/utils/index.ts	269	normalize
src/utils/index.ts	7	escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts	25	BUILD
src/compiler/app-core/app-data.ts	115	Env
src/compiler/app-core/app-data.ts	117	NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts	123	updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts	61	satisfies
src/compiler/types/validate-primary-package-output-target.ts	61	Record
src/testing/puppeteer/puppeteer-declarations.ts	485	WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts	7	writeFetchSuccessSync

[christian-bromann]

The change looks good to me 👍

I will have someone else from the @ionic-team/stencil team review this as well.

[alicewriteswrongs]

code itself looks good and I think this change makes sense! Just had a question about the configuration naming

[Sukaato]

How can I find out if the compiler is in build mode to retrieve only tasks that have `taskShouldRun: 'onBuildOnly'

[christian-bromann]

@Sukaato the BuildOptions have a isWatch flag that can help you to determine whether we are in watch mode or not. So if the flag is set you are only call it if the user has set taskShouldRun to always, otherwise only if onBuildOnly is set.

[Sukaato]

Correction done

[Sukaato]

any update @alicewriteswrongs ?

[christian-bromann]

@Sukaato there seems to be a linter issue in src/declarations/stencil-public-compiler.ts, mind running npm run prettier?

[christian-bromann]

@Sukaato seems like still some lint issues:

> npm run prettier.base -- --list-different


> @stencil/core@4.1[7](https://github.com/ionic-team/stencil/actions/runs/8913029708/job/24479044933?pr=5541#step:5:8).2 prettier.base
> prettier --cache "./({bin,scripts,src,test}/**/*.{ts,tsx,js,jsx})|bin/stencil|.github/(**/)?*.(yml|yaml)|*.js" --list-different

src/declarations/stencil-public-compiler.ts