fix: correctly handle svg class attribute within parseClassList
#6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
An error is thrown during the virtual DOM render when attempting to parse the class list of an
svgtag inside a custom element. This occurs because theclassproperty on ansvgelement is not astringbut an object of typeSVGAnimatedString.What is the new behavior?
Correctly parse the class list of a
svgelements.Documentation
None.
Does this introduce a breaking change?
Testing
Added a new wdio test, which checks for
console.errorlogs.Other information
None.