fix(runtime): append newChild if parent node doesn't match with patched node #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@itsjustaplant thanks for raising the PR, mind creating a test to ensure we don't regress on this? I recommend to create a WebdriverIO test as it provides the most flexibility creating the test. Let me know if you have any questions. |
itsjustaplant
force-pushed
the
fix/runtime_patchInsertBefore_node_not_found_error
branch
from
cba9889 to
19db966
Compare
itsjustaplant
changed the title
|
Hi @christian-bromann , I am unable to reproduce this issue in either a plain Stencil app or WebdriverIO tests. I believe that this only happens in React apps. PS: I replaced the unpatched insertBefore with appendChild as a fallback method as i believe that appendChild is safer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: #6140
What is the new behavior?
If patched node (this) is not the same node of currentChild, it uses appendChild to insert the newChild to patched node
Documentation
Does this introduce a breaking change?
Testing
Other information