Fixes ThreadPool Exhaustion with ProgressListener #1070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
FindAllReferences
, I noticed it was taking extremely long to get results back. I noticed the logs coming in about every second which gave me a hunch that it might be threadpool exhaustion. I went digging and found a good article for debugging this sort of things.Using
dotnet-stack
I was able to trace down the culprit:Turns out I shouldn't be using
PostAndReply
as it blocks threads.