Correctly assign user-provided FSI args and target netstandard when appropriate #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
force-pushed
the
fix-weird-script-ref-errors
branch
from
0c3c034
to
d653645
Compare
baronfel
changed the title
baronfel
force-pushed
the
fix-weird-script-ref-errors
branch
2 times, most recently
from
a60d6c1
to
a80b08d
Compare
For netcore/netfx we should always explicitly provide the targetprofile, because the impacts how reference resolution works (ie which primary assembly we look for and key off of), and we should also provide any static additional arguments as the 'otherFlags' argument. In addition, we need to explicitly not provide an mscorlib reference when targeting netstandard, as that re-enables some of the legacy paths. Finally, there was a bug in the handling of the 'replace refs' function that was overwriting all of the OtherOptions instead of modifying just the framework refs.
baronfel
force-pushed
the
fix-weird-script-ref-errors
branch
from
a80b08d
to
db8baa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #503 by fixing how we assign FSI options for netcore.
For netcore/netfx we should always explicitly provide the targetprofile, because the impacts how reference resolution works (ie which primary assembly we look for and key off of), and we should also provide any static additional arguments as the 'otherFlags' argument.
In addition, we need to explicitly not provide an mscorlib reference when targeting netstandard, as that re-enables some of the legacy paths.
Finally, there was a bug in the handling of the 'replace refs' function that was overwriting all of the OtherOptions instead of modifying just the framework refs.