v5.7.2 does not work

[mrboring]

Describe the bug

v5.7.2 does not work in vscode.

• No icon in side bar
• No intellisense
• No popup when mousing over a value
• Trying Alt+Enter gives command 'fsi.SendSelection' not found

I saw another user having the same issue in the editor_support Slack channel.

Steps to reproduce

1. Open an existing fsx file.
2. Mouse pointer over a value does not show the popup.
3. Highlight some code and press Alt+Enter.

Expected behaviour

• Icon in side bar
• Insellisense
• Popup when hovering over a value
• Alt+Enter should run the selected code in FSI

Machine info

• OS: Windows 10 10.0.19043 Build 19043
• .NET SDK version: 5.0.400]
• Ionide version: 5.7.2
• VSCode version: 1.60.0 (user setup)

Additional context

Reverting to v5.7.1 resolves the issue.

[open-collective-bot]

Hey @mrboring 👋,

Thank you for opening an issue. We will get back to you as
soon as we can. Also, check out our OpenCollective and consider
backing us.

https://opencollective.com/ionide

PS.: We offer backer support for all backers. Don't forget to add backer label when you start backing us 😄

[forki]

yeah same here. 5.7.2 seems to be broken somehow /cc @baronfel @Krzysztof-Cieslak

[alfonsogarciacaro]

At least it's not only me, I thought I messed too much with these extensions and was crazy removing and reinstalling VS Code. @Krzysztof-Cieslak says here the update is working for him 😕 ionide/FsAutoComplete#830 (comment)

Weird thing is the VS Code logs don't say anything.

I tried by adding a debugger to the "activate" function of Ionide and running an Extension host and did get some errors about missing modules (like "Cannot find module bufferutil") although the stack didn't include Ionide code so not entirely sure if the errors were caused by it. Can it happen that in some machines these missing modules are installed globally and that's why the update works?

[shazmodan]

I have the same problem. Reverting to 5.7.1 still works however.

[alfonsogarciacaro]

Now properly debugging after building this repo. Still not sure what the problem is, but it seems the extension hangs when trying to run cmd /C where dotnet.exe to find the path of dotnet in windows. The "exit" event in the spawned process is never called (nor "close" apparently).

[baronfel]

Thanks, this is probably a result of some typing definition updates that came along with the FSAC update. I'll work on rolling those back early this morning and releasing a new version. Gotta get some coffee first though!

[alfonsogarciacaro]

Just the change from #1579 makes 5.7.2 work on my computer. Now you ask me why it was working before... I have no idea.

As an aside, in this helper the options set at the top are not actually being used when calling spawn. It doesn't really seem to matter because the command is (at least the times the function was hit when I was debugging) either a global tool or an absolute path: https://github.com/ionide/ionide-vscode-helpers/blob/5afa130a6985c2de3b87e72ce69db2189fe64f25/src/Helpers.fs#L144-L152

[baronfel]

5.7.3 is rolling out now, and @alfonsogarciacaro I've also made the suggested fix to the helpers - thanks for that spot!

[forki]

I can confirm. It's fixed for me. Thanks folks

[mrboring]

v5.7.3 is working fine for me. Thanks for the quick response!

[akemimadoka]

v5.7.3 still not working on Ubuntu for me, should I open another issue?