Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to turn off test discovery on workspace load #1919

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

farlee2121
Copy link
Contributor

WHAT

Add a configuration setting to turn off automatic test discovery on workspace load.

WHY

@TheAngryByrd was having issues with slowness due to concurrent builds on certain project

@baronfel
Copy link
Contributor

Just to make sure I understand - if a user uses this setting, are they able to manually invoke test discovery at some later point?

@farlee2121
Copy link
Contributor Author

Yes. They can trigger test discovery with the refresh button in the test explorer

@baronfel baronfel added the needs-documentation A label for items that add or change config settings or behavior, and so need docs updates label Aug 29, 2023
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@baronfel
Copy link
Contributor

Lovely! @TheAngryByrd I'm away on vacation, would you be down to push a hotfix release with this so that you aren't impacted?

@TheAngryByrd
Copy link
Member

Lovely! @TheAngryByrd I'm away on vacation, would you be down to push a hotfix release with this so that you aren't impacted?

STOP LOOKING AT GITHUB/SLACK/DISCORD

@TheAngryByrd
Copy link
Member

idk what's up with CI but gonna merge

@TheAngryByrd TheAngryByrd merged commit 1b7010b into ionide:main Aug 31, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-documentation A label for items that add or change config settings or behavior, and so need docs updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants