Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little cleanup in src/Components #1921

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Sep 3, 2023

WHAT

🤖 Generated by Copilot at d76ef05

This pull request improves the code quality and consistency of some components in the ionide-vscode-fsharp extension. It simplifies some patterns, removes unused variables, fixes a typo, and changes a comment style.

🤖 Generated by Copilot at d76ef05

Diagnostics fixed
Comments and patterns refined
Code like autumn leaves

📝💅🧹

WHY

A little cleanup in src/Components like removing unused parameters, prefixing with _ etc.

HOW

🤖 Generated by Copilot at d76ef05

  • Fix typo in comment template for reporting issues (link)
  • Change comment style from triple slash to double slash in module Diagnostics to follow F# style guide (link)
  • Simplify pattern matching on project model and loading state in SolutionExplorer.fs by removing unused variables and arguments (link, link, link, link)

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 Thanks!!

@TheAngryByrd TheAngryByrd merged commit 63a98d4 into ionide:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants