Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a leading space to the default prefix in LineLens.config #1928

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Sep 13, 2023

WHAT

Add a leading space to the default prefix string in the shared line lens code.

WHY

refs #1924

Note that this only updates the default value and doesn't fix the actual issue, it just seemed reasonable to me for this default to have a leading space to match the one at https://github.com/ionide/ionide-vscode-fsharp/blob/61c4d71ef5b255a77aa368548530380174d39ac4/src/Components/LineLens/LineLens.fs#L35C53-L35C53

I'll do a test PR shortly for another possible change related to the issue

HOW

It's just a space in the prefix string.

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this actually happened. Thanks for this!

@TheAngryByrd TheAngryByrd merged commit b4523f4 into ionide:main Sep 14, 2023
1 of 2 checks passed
@Numpsy Numpsy deleted the users/rw/default_sep branch September 14, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants