Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check user provided string for any content before renaming file to it #1932

Merged

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Sep 15, 2023

WHAT

🤖 Generated by Copilot at 3807e8d

This pull request enhances the file renaming functionality in the SolutionExplorer component. It adds validation for file names and error handling for renaming operations.

🤖 Generated by Copilot at 3807e8d

No empty file names
SolutionExplorer shines
Autumn bugs swept away

📝🐛🚀

WHY

Currently, if the user just hits enter in the textbox we end up with a file named .fs.
So let's check for any content given by the user.

HOW

🤖 Generated by Copilot at 3807e8d

  • Prevent creating empty files when renaming nodes in the solution explorer by checking the new file name is not null or empty (link)
  • Handle any other possible values of the new file name option with a wildcard case to avoid errors (link)

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TheAngryByrd TheAngryByrd merged commit 2be2d7b into ionide:main Sep 15, 2023
2 of 3 checks passed
@dawedawe dawedawe deleted the check_string_content_before_renaming_file branch September 15, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants