Bug xunit theory #1936
Merged
Bug xunit theory #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditional was removed unintentionally. Perhaps clobbered in a merge? ionide@61c4d71#r127656246
Each test framework has different ideas about the data that belongs in each name field. The quirks are especially bad around parameterized tests. So, I have to piece together a consistent fully qualified name from different field combinations for different frameworks
|
There aren't any clear wholistic solutions to the issues with parameterized tests. |
|
Might be worth opening issues on the respective frameworks asking questions of how to get at them. Also maybe we should have it documented the features/limitations of each framework currently. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
#1935
Parameterized tests were never finishing for xUnit and MSTest.
This gets them completing properly.
HOW
Piece together consistent fully qualified test names from different fields based on the test framework.
Merge?
I'm not sure if this PR is worth merging yet.
It does get parameterized tests completing and status showing across xUnit, nUnit, MSTest, and expecto.
However, MSTest and xUnit still can't individually run the theory cases (some kind of filter issue), and the theory cases aren't nested under their shared method.
This makes it a impossible to run the theory test without running a larger grouping of tests.