Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test explorer zsh #1940

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix test explorer zsh #1940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Components/TestExplorer.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,12 +557,12 @@ module DotnetCli =
let filter =
match filterExpression with
| None -> Array.empty
| Some filterExpression -> [| "--filter"; filterExpression |]
| Some filterExpression -> [| "--filter"; $"\"{filterExpression}\"" |]

if filter.Length > 0 then
logger.Debug("Filter", filter)

let! _, stdOutput, stdError =
let! errored, stdOutput, stdError =
dotnetTest
cancellationToken
projectPath
Expand All @@ -571,7 +571,9 @@ module DotnetCli =
shouldDebug
[| "--no-build"; yield! filter |]

logger.Debug("Test run exitCode", stdError)
match errored with
| Some error -> logger.Error("Test run failed - %s - %s - %s", error, stdOutput, stdError)
| None -> logger.Debug("Test run exitCode - %s - %s", stdOutput, stdError)

return (stdOutput + stdError)
}
Expand Down