Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix RBAC to allow IonosCloudMachine Controller updating secrets #116

Merged
merged 3 commits into from
May 7, 2024

Conversation

jriedel-ionos
Copy link
Contributor

What is the purpose of this pull request/Why do we need it?
This PR gives the IonosCloudMachine Controller permissions to update secrets. This was not possible before, which led to errors when the controller was trying to update the secret.

Description of changes:
Fix RBAC to allow IonosCloudMachine controller to update secrets.

Checklist:

@piepmatz
Copy link
Contributor

piepmatz commented May 7, 2024

Both controllers use the credential secret and update the finalizer, so the kubebuilder marker should be present in both files.

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jriedel-ionos jriedel-ionos merged commit 8830c9a into main May 7, 2024
9 checks passed
@jriedel-ionos jriedel-ionos deleted the fix-rbac-allow-updating-secrets branch May 7, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants