Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ allow setting dhcp for additional networks #203

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

lubedacht
Copy link
Contributor

@lubedacht lubedacht commented Aug 7, 2024

What is the purpose of this pull request/Why do we need it?

Some people might want to have a custom DHCP server running and therefore would like to disable DHCP for additional networks.

Description of changes:

Additional networks can now disable DHCP. The default value is true

Checklist:

  • Unit Tests added
  • Includes emojis

Copy link

sonarcloud bot commented Aug 7, 2024

Copy link
Contributor

@jriedel-ionos jriedel-ionos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lubedacht lubedacht merged commit d9080d1 into main Aug 8, 2024
10 checks passed
@lubedacht lubedacht deleted the make-dhcp-configurable branch August 8, 2024 09:45
@jriedel-ionos jriedel-ionos added this to the v0.5.0 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants